From 8b1656c76fac48423f612e9712664ec2f08766de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sascha=20I=C3=9Fbr=C3=BCcker?= Date: Tue, 26 Nov 2024 08:15:58 +0100 Subject: [PATCH] fix: restore hover effect on pie charts when using Lumo theme classes (#6850) --- .../vaadin/flow/component/charts/themes/LumoDarkTheme.java | 6 ------ .../vaadin/flow/component/charts/themes/LumoLightTheme.java | 6 ------ 2 files changed, 12 deletions(-) diff --git a/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoDarkTheme.java b/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoDarkTheme.java index 95715ed1866..c4ce9aad611 100644 --- a/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoDarkTheme.java +++ b/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoDarkTheme.java @@ -9,8 +9,6 @@ package com.vaadin.flow.component.charts.themes; import com.vaadin.flow.component.charts.model.AbstractDataLabels; -import com.vaadin.flow.component.charts.model.Hover; -import com.vaadin.flow.component.charts.model.States; import com.vaadin.flow.component.charts.model.style.AxisStyle; import com.vaadin.flow.component.charts.model.style.Color; import com.vaadin.flow.component.charts.model.style.FontWeight; @@ -164,10 +162,6 @@ public LumoDarkTheme() { setDataLabelsDefaults(getPlotOptions().getPyramid().getDataLabels()); setDataLabelsDefaults(getPlotOptions().getSpline().getDataLabels()); setDataLabelsDefaults(getPlotOptions().getWaterfall().getDataLabels()); - - States states = new States(); - states.setHover(new Hover(false)); - getPlotOptions().getPie().setStates(states); } protected void setDataLabelsDefaults(AbstractDataLabels labels) { diff --git a/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoLightTheme.java b/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoLightTheme.java index 291aba07987..4e6d31755ff 100644 --- a/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoLightTheme.java +++ b/vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/themes/LumoLightTheme.java @@ -9,8 +9,6 @@ package com.vaadin.flow.component.charts.themes; import com.vaadin.flow.component.charts.model.AbstractDataLabels; -import com.vaadin.flow.component.charts.model.Hover; -import com.vaadin.flow.component.charts.model.States; import com.vaadin.flow.component.charts.model.style.AxisStyle; import com.vaadin.flow.component.charts.model.style.Color; import com.vaadin.flow.component.charts.model.style.FontWeight; @@ -164,10 +162,6 @@ public LumoLightTheme() { setDataLabelsDefaults(getPlotOptions().getPyramid().getDataLabels()); setDataLabelsDefaults(getPlotOptions().getSpline().getDataLabels()); setDataLabelsDefaults(getPlotOptions().getWaterfall().getDataLabels()); - - States states = new States(); - states.setHover(new Hover(false)); - getPlotOptions().getPie().setStates(states); } protected void setDataLabelsDefaults(AbstractDataLabels labels) {