From 11f23094e02febdac8a7909eb49dbb66fac68d02 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Fri, 11 Oct 2024 14:15:20 +0400 Subject: [PATCH] fix: do not trigger data communicator reset when no filters --- .../main/java/com/vaadin/flow/component/grid/Grid.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java b/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java index 237df05b2b4..db9b6bf99fe 100755 --- a/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java +++ b/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java @@ -1448,8 +1448,10 @@ public UpdateQueueData getUpdateQueueData() { private SerializableFunction classNameGenerator = item -> null; private SerializableFunction partNameGenerator = item -> null; - private SerializablePredicate dropFilter = item -> true; - private SerializablePredicate dragFilter = item -> true; + private SerializablePredicate defaultDropFilter = item -> true; + private SerializablePredicate defaultDragFilter = item -> true; + private SerializablePredicate dropFilter = defaultDropFilter; + private SerializablePredicate dragFilter = defaultDragFilter; private Map> dragDataGenerators = new HashMap<>(); private Registration dataProviderChangeRegistration; @@ -4566,7 +4568,9 @@ public Registration addDragEndListener( public void setDropMode(GridDropMode dropMode) { getElement().setProperty("dropMode", dropMode == null ? null : dropMode.getClientName()); - getDataCommunicator().reset(); + if (dragFilter != defaultDragFilter || dropFilter != defaultDropFilter) { + getDataCommunicator().reset(); + } } /**