From 04dc6229de9c41adc637b01626ea902941d93399 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Fri, 11 Oct 2024 14:38:36 +0400 Subject: [PATCH] add a comment --- .../main/java/com/vaadin/flow/component/grid/Grid.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java b/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java index db9b6bf99fe..fa137626666 100755 --- a/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java +++ b/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java @@ -4568,7 +4568,13 @@ public Registration addDragEndListener( public void setDropMode(GridDropMode dropMode) { getElement().setProperty("dropMode", dropMode == null ? null : dropMode.getClientName()); - if (dragFilter != defaultDragFilter || dropFilter != defaultDropFilter) { + + // Workaround to prevent scroll position reset when setting dropMode + // dynamically on drag start in tree grids. This can be removed when + // Flow will provide a way to request refresh for only items that + // are in the viewport. + if (dragFilter != defaultDragFilter + || dropFilter != defaultDropFilter) { getDataCommunicator().reset(); } }