Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and provide some I18N for design. #637

Closed
vaadin-bot opened this issue Sep 10, 2015 · 6 comments
Closed

Design and provide some I18N for design. #637

vaadin-bot opened this issue Sep 10, 2015 · 6 comments
Labels
Stale Inactive issue marked for closing

Comments

@vaadin-bot
Copy link

Originally by @denis-anisimov


At the moment it's not possible to create design which is targeted to be used for several locales.
Any string is set into HTML as is.

Core framework doesn't allow to embed any I18N, so we need some support from core.

I would suggest:

  • design SPI for I18N support in the framework. So there should be a way to plug any I18N provider (f.e. just deign an interface and set it via setter into DesignContext) which fetches the localized string by the key.
  • Provide a syntax in HTML which saves the key instead of String value itself.

F.e. an attribute for HTML which means that Text node is not a vlaue but a key which should be used to retrieve real value from a provider:

LBL_Title

or use directly an element instead of Text node

LBL_Title

Provider should be used to get real values on deserialization.
Serialization would be tricky since component doesn't contain the key which has been used to set property value.
It requires some thinking.

On the designer side we can provide a default Provider which uses properties to store pairs "key=value" (Java property bundles).

By default: no providers , all values are stored as is.

User should be able to implement it's own provider to plug it's own way to fetch values for the key.


Imported from https://dev.vaadin.com/ issue #18844

@vaadin-bot
Copy link
Author

Originally by @jdahlstrom


I18n support for the core framework is something that's been requested for years and was originally on the 7.0 wishlist (#5313). It's obviously a very complex issue.

@ripla
Copy link
Contributor

ripla commented Apr 26, 2017

Related FW issue: vaadin/framework#1161

@stale
Copy link

stale bot commented Mar 26, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a few things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are many duplicates in our issue tracker, so it is possible that the issue is already tackled.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Inactive issue marked for closing label Mar 26, 2018
@stale
Copy link

stale bot commented Sep 22, 2018

The issue was automatically closed due to inactivity. If you found some new details please comment on the issue so that maintainers can re-open it.

@stale stale bot closed this as completed Sep 22, 2018
@mvysny
Copy link
Member

mvysny commented Nov 4, 2020

Still an issue with Vaadin 14 and the Designer: vaadin/flow#3906

@TatuLund
Copy link

TatuLund commented Nov 4, 2020

See also vaadin/flow#3906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive issue marked for closing
Projects
None yet
Development

No branches or pull requests

5 participants