Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split up into components with props #2

Merged
merged 10 commits into from
Oct 19, 2023
Merged

refactor: split up into components with props #2

merged 10 commits into from
Oct 19, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

No description provided.

@mxmlnwbr mxmlnwbr requested a review from rschlaefli October 18, 2023 14:45
@mxmlnwbr mxmlnwbr self-assigned this Oct 18, 2023
@mxmlnwbr
Copy link
Collaborator Author

Please Review @rschlaefli 👍

rschlaefli
rschlaefli requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@rschlaefli rschlaefli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add typescript interfaces for the separate components

@mxmlnwbr
Copy link
Collaborator Author

TODO: add typescript interfaces for the separate components

review reviewed code @rschlaefli :)

@rschlaefli rschlaefli changed the title Draft: Restructure refactor: split up into components with props Oct 19, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
6.6% 6.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rschlaefli rschlaefli merged commit ba3cf3f into main Oct 19, 2023
3 of 6 checks passed
@rschlaefli rschlaefli deleted the restructure branch October 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli requested changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli