fix(app): supervisedBy unassigned resolved #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschlaefli
requested changes
Dec 7, 2023
src/components/ProposalMeta.tsx
Outdated
| if (!proposalDetails) return null | ||
|
|
||
| const getSupervisedBy = () => { |
There was a problem hiding this comment.
perfect use case for https://react.dev/reference/react/useMemo -> the computation is not expensive per se, but it could become more expensive, and good to understand why use memo could be valuable in such cases
There was a problem hiding this comment.
@rschlaefli,
Cannot call Hooks conditionally problem
https://legacy.reactjs.org/docs/hooks-rules.html
There was a problem hiding this comment.
@mxmlnwbr yes, it requires a reordering to conform with the hooks rule -> pushed a commit that shows an example that should work. PR should be ready for merge :)
rschlaefli
approved these changes
Dec 9, 2023
rschlaefli
force-pushed
the
supervisedBy
branch
from
a906c0b to
7b2b6de
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing supervisedBy: unassigned everywhere. It now shows the real supervisor, if there is one present.
***By the way: still don't know why my tailwind is always reordering stuff 🍔 ***