Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(app): filter & proposalId to url #11

Merged
merged 5 commits into from
Nov 21, 2023
Merged

enhance(app): filter & proposalId to url #11

merged 5 commits into from
Nov 21, 2023

Conversation

mxmlnwbr
Copy link
Collaborator

Added the state of the current filter and selected proposal (proposalId) to the url. Improvement for sharing via link.

@mxmlnwbr mxmlnwbr requested a review from rschlaefli November 13, 2023 10:20
@mxmlnwbr mxmlnwbr self-assigned this Nov 13, 2023
@mxmlnwbr mxmlnwbr marked this pull request as ready for review November 15, 2023 08:37
@mxmlnwbr
Copy link
Collaborator Author

@rschlaefli
Please review! Not sure if everything makes sense the way I've implemented it.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mxmlnwbr mxmlnwbr merged commit b73f12a into dev Nov 21, 2023
3 checks passed
@mxmlnwbr mxmlnwbr deleted the url branch November 21, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlaefli rschlaefli rschlaefli approved these changes

Assignees

@mxmlnwbr mxmlnwbr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmlnwbr @rschlaefli