Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog test: Check if the changelog file name matches the package name #9480

Open
cbbayburt opened this issue Nov 15, 2024 · 3 comments
Open
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@cbbayburt
Copy link
Contributor

Make sure the name of the .changes file starts with the correct package name.

For example, if a change file inside java/ directory is named spacewalk-web.changes.cbbayburt.myfeature , it should be rejected.

@cbbayburt cbbayburt added the github_actions Pull requests that update GitHub Actions code label Nov 15, 2024
@Etheryte
Copy link
Member

Maybe I misunderstood the description, but isn't this the exact opposite of what we want? In my opinion it would make more sense to include every .changes file, even if the author accidentally misnamed them, no?

@cbbayburt
Copy link
Contributor Author

IIUC, the problem is if the file name (the first part) doesn't match the package, the tool that compiles the changelog for releng ignores it. I'm not actually sure if it would make better sense to fix it like this, or on the compiling tool. I should look into it and update this card accordingly.

@Etheryte
Copy link
Member

Yeah that sounds good. Thanks a lot for looking into it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

2 participants