Calendar functionality #18

VJagiasi · 2024-07-05T07:36:32Z

Notion ticket link

Calendar Absence Creation and Deletion

Implementation description

Implemented a fully functional calendar with the ability to add and delete absences which gets stored in the database and is in sync

Steps to test

run this in light mode as it's not styled yet completely for dark mode

Ensure the database is running
npm run dev and go to localhost:3000/calendar
Try adding and deleting multiple absences and check if they are getting updated in the database

What should reviewers focus on?

Absences getting synced with the database and the calendar on the frontend

Checklist

My PR name is descriptive and in imperative tense
My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

prisma/schema.prisma

src/components/InputForm.tsx

src/pages/calendar.tsx

phamkelly17 · 2024-07-10T01:21:45Z

src/components/InputForm.tsx

+          placeholder="Enter substitute teacher ID"
+          value={substituteTeacherId}
+          onChange={(e) => setSubstituteTeacherId(e.target.value)}
+          color="black"


nit: this might not matter because this ticket is more about frontend than styling, but on these number inputs if you scroll on your trackpad the number changes which is annoying

doesn't seem to happen when I try to fill out the input form, do you mean it just starts changing as soon as you scroll?

phamkelly17 · 2024-07-10T01:29:45Z

src/pages/calendar.tsx

+    FetchEvents();
+  }, []);
+
+  const FetchEvents = async () => {


i think this should fetch from the db based on if its in day, week, or month mode. I feel like this would be better than grabbing all absences in the db, especially if there are be lot of absences. The useEffect can run this function every time the view is changed.

but we anyways have to fetch them initially for month view in the beginning so won't it be unnecessary to fetch multiple times for different views

phamkelly17 · 2024-07-10T01:33:38Z

Couldn't actually test functionality because I'm getting this error. So I'm wondering if you've gotten this same error.

My main suggestion is how all the Absences are called Events. Imo event is a very general term and they're all absences so I think it could be clearer if all those variables were called Absences

ChinemeremChigbo

I think a lot of unnecessary files where changed during your rebasing / merging with main. I would take another look to make sure only the changes you intend to make are being made.

.env.sample

.prettierignore 2

.husky/pre-commit

.prettierrc 2

Dockerfile

docker-compose.yml

pnpm-lock.yaml

prisma/schema.prisma

src/pages/index.tsx

tsconfig.json

ChinemeremChigbo

Add steps for seeding to Steps to test

…com/uwblueprint/sistema into vihaan-anant/calendar-functionality

ChinemeremChigbo · 2024-10-19T22:02:20Z

Dockerfile

@@ -17,8 +17,7 @@ RUN npm install
 EXPOSE 3000

 # Run the application
-CMD echo "Waiting for database to be ready..." && \
-    echo "Running Prisma commands..." && \
+CMD echo "Running Prisma commands..." && \


Revert changes here.

ChinemeremChigbo · 2024-10-19T22:02:57Z

package.json

Revert changes here

ChinemeremChigbo · 2024-10-21T03:56:14Z

package.json

@@ -44,7 +44,7 @@
    "@types/react-dom": "^18.0.0",
    "@typescript-eslint/eslint-plugin": "^8.8.0",
    "@typescript-eslint/parser": "^8.8.0",
-    "eslint": "^8.57.1",
+    "eslint": "^8.57.0",


ChinemeremChigbo · 2024-10-21T03:56:18Z

package.json

    "prisma": "^5.16.0",
+    "postgres": "^3.4.4",


ChinemeremChigbo · 2024-10-21T03:56:24Z

package.json

    "@mui/material": "^5.15.20",
    "@mui/system": "^5.15.20",
+    "@faker-js/faker": "^8.4.1",


ChinemeremChigbo · 2024-10-21T03:56:27Z

package.json

@@ -2,7 +2,7 @@
  "private": true,
  "scripts": {
    "dev": "next dev",
-    "build": "next build",
+    "build": "prisma generate && prisma migrate && next build",


VJagiasi requested review from ChinemeremChigbo and phamkelly17 July 5, 2024 07:36