From 5ced295a59aea486be8e0897286795d912be6345 Mon Sep 17 00:00:00 2001
From: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Date: Tue, 16 Apr 2024 16:15:44 +0200
Subject: [PATCH] slabtop: move unit tests to parse.rs

---
 src/uu/slabtop/src/parse.rs   | 65 +++++++++++++++++++++++++++++++++
 tests/by-util/test_slabtop.rs | 67 -----------------------------------
 2 files changed, 65 insertions(+), 67 deletions(-)

diff --git a/src/uu/slabtop/src/parse.rs b/src/uu/slabtop/src/parse.rs
index aaacad3f..0e038d3f 100644
--- a/src/uu/slabtop/src/parse.rs
+++ b/src/uu/slabtop/src/parse.rs
@@ -293,3 +293,68 @@ pub(crate) fn parse_data(line: &str) -> Option<(String, Vec<u64>)> {
         )
     })
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_parse_version() {
+        let test = "slabinfo - version: 2.1";
+        assert_eq!("2.1", parse_version(test).unwrap())
+    }
+
+    #[test]
+    fn test_parse_meta() {
+        let test="# name            <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : slabdata <active_slabs> <num_slabs> <sharedavail>";
+
+        let result = parse_meta(test);
+
+        assert_eq!(
+            result,
+            [
+                "active_objs",
+                "num_objs",
+                "objsize",
+                "objperslab",
+                "pagesperslab",
+                "limit",
+                "batchcount",
+                "sharedfactor",
+                "active_slabs",
+                "num_slabs",
+                "sharedavail"
+            ]
+        )
+    }
+
+    #[test]
+    fn test_parse_data() {
+        // Success case
+
+        let test = "nf_conntrack_expect      0      0    208   39    2 : tunables    0    0    0 : slabdata      0      0      0";
+        let (name, value) = parse_data(test).unwrap();
+
+        assert_eq!(name, "nf_conntrack_expect");
+        assert_eq!(value, [0, 0, 208, 39, 2, 0, 0, 0, 0, 0, 0]);
+
+        // Fail case
+        let test =
+            "0      0    208   39    2 : tunables    0    0    0 : slabdata      0      0      0";
+        let (name, _value) = parse_data(test).unwrap();
+
+        assert_ne!(name, "nf_conntrack_expect");
+    }
+
+    #[test]
+    fn test_parse() {
+        let test = include_str!("../../../../tests/fixtures/slabtop/data.txt");
+        let result = SlabInfo::parse(test.into()).unwrap();
+
+        assert_eq!(result.fetch("nf_conntrack_expect", "objsize").unwrap(), 208);
+        assert_eq!(
+            result.fetch("dmaengine-unmap-2", "active_slabs").unwrap(),
+            16389
+        );
+    }
+}
diff --git a/tests/by-util/test_slabtop.rs b/tests/by-util/test_slabtop.rs
index a4b1c4d6..2e402610 100644
--- a/tests/by-util/test_slabtop.rs
+++ b/tests/by-util/test_slabtop.rs
@@ -1,11 +1,4 @@
 use crate::common::util::TestScenario;
-use crate::test_slabtop::parse::parse_data;
-use crate::test_slabtop::parse::parse_meta;
-use crate::test_slabtop::parse::parse_version;
-use crate::test_slabtop::parse::SlabInfo;
-
-#[path = "../../src/uu/slabtop/src/parse.rs"]
-mod parse;
 
 #[test]
 fn test_invalid_arg() {
@@ -16,63 +9,3 @@ fn test_invalid_arg() {
 fn test_slabtop() {
     new_ucmd!().arg("--help").succeeds().code_is(0);
 }
-
-#[test]
-fn test_parse_version() {
-    let test = "slabinfo - version: 2.1";
-    assert_eq!("2.1", parse_version(test).unwrap())
-}
-
-#[test]
-fn test_parse_meta() {
-    let test="# name            <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> : slabdata <active_slabs> <num_slabs> <sharedavail>";
-
-    let result = parse_meta(test);
-
-    assert_eq!(
-        result,
-        [
-            "active_objs",
-            "num_objs",
-            "objsize",
-            "objperslab",
-            "pagesperslab",
-            "limit",
-            "batchcount",
-            "sharedfactor",
-            "active_slabs",
-            "num_slabs",
-            "sharedavail"
-        ]
-    )
-}
-
-#[test]
-fn test_parse_data() {
-    // Success case
-
-    let test = "nf_conntrack_expect      0      0    208   39    2 : tunables    0    0    0 : slabdata      0      0      0";
-    let (name, value) = parse_data(test).unwrap();
-
-    assert_eq!(name, "nf_conntrack_expect");
-    assert_eq!(value, [0, 0, 208, 39, 2, 0, 0, 0, 0, 0, 0]);
-
-    // Fail case
-    let test =
-        "0      0    208   39    2 : tunables    0    0    0 : slabdata      0      0      0";
-    let (name, _value) = parse_data(test).unwrap();
-
-    assert_ne!(name, "nf_conntrack_expect");
-}
-
-#[test]
-fn test_parse() {
-    let test = include_str!("../fixtures/slabtop/data.txt");
-    let result = SlabInfo::parse(test.into()).unwrap();
-
-    assert_eq!(result.fetch("nf_conntrack_expect", "objsize").unwrap(), 208);
-    assert_eq!(
-        result.fetch("dmaengine-unmap-2", "active_slabs").unwrap(),
-        16389
-    );
-}