-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Illumos #48
Conversation
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 94.97% 94.98% +0.01%
==========================================
Files 4 4
Lines 956 958 +2
==========================================
+ Hits 908 910 +2
Misses 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It seems Github actions dies on a style check in an integration test. Oddly enough this PR doesn't change that code. I think the style check might have been updated? Causing it to suddenly fail on this piece of existing code?
|
Hmm, odd that it didn't show up as failures in the prior merge with the CI code change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit... we generally use active/imperative voice for commit messages.
When you rebase onto the new 'main', would you mind changing the commit message to "add support for Illumos"?
@siepkes , the updated 'main' is now available. If you rebase, I expect that all tests should pass. |
This commit introduces support for Illumos, an (Open) Solaris derivative. It also clarifies the documentation a bit on why the domainname field is missing for OS'es like the BSD's and Illumos.
Your changes seem to have worked. All checks passed! |
This commit introduces support for Illumos, an (Open) Solaris derivative.
uname -o
on Illumos returnsillumos
.It also clarifies the documentation a bit on why the domainname field is missing for OS'es like the BSD's and Illumos.