find: Implement -ok[dir] predicate.
#369
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 66.51% 66.32% -0.19%
==========================================
Files 36 36
Lines 4366 4380 +14
Branches 982 984 +2
==========================================
+ Hits 2904 2905 +1
- Misses 1062 1072 +10
- Partials 400 403 +3 ☔ View full report in Codecov by Sentry. |
sylvestre
force-pushed
the
implement-8
branch
3 times, most recently
from
36d1a4c to
fe3e4d0
Compare
|
@hanbings do you have an update on this ? thanks :) |
sylvestre
force-pushed
the
implement-8
branch
from
fe3e4d0 to
18b88ff
Compare
tavianator
reviewed
Sep 9, 2024
| path_to_file.to_string_lossy() | ||
| ); | ||
| #[allow(clippy::explicit_write)] | ||
| write!(stdout(), "{}", tips).unwrap(); |
There was a problem hiding this comment.
POSIX specifies
- The -ok primary shall write a prompt to standard error
- In the POSIX locale, the last non-<blank> in the prompt shall be '?'
There was a problem hiding this comment.
Thanks! I overlooked these, I will fix them later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: #8