-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove time dependency from date #4952
Conversation
Also upgrades humantime_to_duration to the latest version, it switched from time to chrono. Because touch still depends on time, its humantime_to_duration package version deviates from the workspace version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was surprisingly easy! I like the choice of letting date
use the workspace dependency and change the Cargo.toml of touch
.
Edit: There's a little issue with cargo deny
still. In my opinion, this can be merged once that's fixed and the rest of the CI is green.
Duplicates of humantime_to_duration and time can be removed when touch switches from time to chrono
Thank you, I have added the duplicates to skipped bans |
@tertsdiepraam I would wait with merging this PR until there is a new version of |
@cakebaker Is it humantime's fault? I thought the problem was just that we now have two versions of humantime (temporarily). |
This was my understanding as well |
@tertsdiepraam yes, humantime 0.3.0 introduces some unnecessary dependencies, among them a "bad" version of |
It is actually chrono that still depends on time, it looks like they are talking about removing it |
I'm sorry, I see this is fixable by removing the old-time feature from chrono. |
Excellent! We'll wait a bit for the next release then. Thanks @cakebaker! |
I pushed a new reelease of this crate (0.3.1) |
Latest patch fixes the transitive dependency on time. Which can now also be removed from the deny skipped bans.
I have upgraded humantime_to_duration and indeed we do not have a transitive dependency on time anymore. Thank you @cakebaker Terts, could you take another look? |
Fuzzing failed because of -d1111111111111111m-m:
|
landing as it is from humantime_to_duration |
opened here: |
Thank you sylvestre |
Also upgrades humantime_to_duration to the latest version, it switched from time to chrono. Because touch still depends on time, its humantime_to_duration package version deviates from the workspace version.
Fixes #4932