-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mv
: expose main functionality for nushell
#5293
Comments
While I noticed |
I think @PThorpe92 was working on this, but didn't mention that here yet. In the meantime, you could try to look at other utils. For example, the ones mentioned here: #5088 (comment). In general though, I think it's nice to make all utils as uniform as possible and I do encourage renaming as part of these PRs. Though more involved refactors should be done separately. |
Yeah I'll have a PR in today on this. |
Got it! |
Part of: nushell/nushell#10446
nushell wants access to our
mv
internals. Which means exposing theexec
function andBehavior
struct. Feel free to rename those to something more sensible for a public API (e.g.move
&Options
, to match the naming scheme fromcp
). There should be documentation for all the public items in the API as well.This is an excellent first issue: feel free to claim this!
We did the same thing for
cp
already. You could use that PR as a guide: #5152The text was updated successfully, but these errors were encountered: