Godot 4.2 support #181
Merged
Godot 4.2 support #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
commented
Dec 3, 2023
| @@ -156,6 +156,13 @@ jobs: | |||
| lfs: true | |||
| submodules: recursive | |||
|
|
|||
| - name: Android dependencies | |||
There was a problem hiding this comment.
This is required due to this error:
sh: 1: /usr/local/lib/android/sdk/ndk/23.2.8568313/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++: not found
bitbrain
commented
Dec 3, 2023
| @@ -57,7 +57,7 @@ jobs: | |||
| fmod-studio-platform-folder: linux/studio/lib/x86_64 | |||
| fmod-library-suffix: so | |||
| godot-executable-download-suffix: linux.x86_64.zip | |||
| godot-executable: Godot_v4.1.2-stable_linux.x86_64 | |||
| godot-executable: Godot_v$GODOT_VERSION-stable_linux.x86_64 | |||
There was a problem hiding this comment.
Standardising this, so one only has to ever bump the env var
bitbrain
commented
Dec 3, 2023
godot-cpp
Outdated
There was a problem hiding this comment.
Updated from godot-4.1.2-stable to godot-4.2-stable
bitbrain
commented
Dec 3, 2023
| @@ -7,6 +7,7 @@ namespace godot { | |||
| class FmodPerformanceData : public RefCounted { | |||
| GDCLASS(FmodPerformanceData, RefCounted); | |||
|
|
|||
| public: | |||
There was a problem hiding this comment.
default access on GDCLASS changed in godot-cpp in godotengine/godot-cpp#1292 from public to private
Hence, we have to make the public access now explicit.
bitbrain
commented
Dec 6, 2023
| fi | ||
| if echo "$line" | grep -q "Failing tests 0"; then |
There was a problem hiding this comment.
This does not work any longer in latest GUT. A better way is to extract the number of passing tests vs total tests and ensure they are the same.
CedNaru
approved these changes
Dec 12, 2023
piiertho
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes this extension compatible with Godot 4.2 - please read comments for more details.