Added ArubaCloud Storage adapter #98
Conversation
| public function __construct(string $root, string $accessKey, string $secretKey, string $bucket, string $region = self::R1_IT, string $acl = self::ACL_PRIVATE) | ||
| { | ||
| parent::__construct($root, $accessKey, $secretKey, $bucket, $region); | ||
| $this->headers['host'] = 's3.arubacloud.com/' . $bucket; |
There was a problem hiding this comment.
I don't think you can put a path in the host header 🧐
| { | ||
| /** | ||
| * Region constants | ||
| * |
There was a problem hiding this comment.
Would you please add a link to the reference material you used to determine the regions?
|
Hello @bannu0snake , Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
thanks @gewenyu99 my discord username is |
|
I'm collecting the usernames in a big spread sheet rn. It's a lot of people to contact, so I'll let you know! |
|
@bannu0snake Sent an invite to |
Related: