-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds ceph adapter file and tests #88
base: main
Are you sure you want to change the base?
adds ceph adapter file and tests #88
Conversation
👏 👏 👏 👏 👏 👏 👏 Thank you for including tests and results! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! 🤯 We left some comments during the review, please check them out.
Please also make sure to:
- to run the formatter to fix the lint errors
- attach a screenshot of successful tests
src/Storage/Device/Ceph.php
Outdated
/** | ||
* Regions constants | ||
*/ | ||
const US_EAST_1 = 'us-east-1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there more regions than these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked docs but couldn't find any specfied regions, I've added the most commonly accepted ones
const US_EAST_1 = 'us-east-1';
const US_EAST_2 = 'us-east-2';
const US_WEST_1 = 'us-west-1';
const US_WEST_2 = 'us-west-2';
I checked in blackblaze adpater and it clearly shows where it is hosted but it not the case with Ceph. I assume all regions would work here which present in S3.php file. Should I add all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they don't have any regions? Maybe we shouldn't add any in here then 🧐
@mugdha273 please address the comments made by Steven. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my latest comments. Please also attach a screenshot of successful tests
src/Storage/Device/Ceph.php
Outdated
/** | ||
* Regions constants | ||
*/ | ||
const US_EAST_1 = 'us-east-1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they don't have any regions? Maybe we shouldn't add any in here then 🧐
@@ -83,7 +83,6 @@ public static function exists($name) | |||
* | |||
* Based on: https://stackoverflow.com/a/38659168/2299554 | |||
* | |||
* @param int $bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm running composer lint these changes are automatically being made. Should I undo it? Because then the tests will fail right?
src/Storage/Storage.php
Outdated
* @param Device $device | ||
* @return void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why were these removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm running composer lint these changes are automatically being made. Should I undo it? Because then the tests will fail right?
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
Hello @mugdha273 Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions/make sure the tests are passing by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
Hi my PR is complete though it is not passing tests. I fetched it from main branch and the tests are failing on main branch also, I've already asked my doubt, waiting for the reply. |
okay thanks @mugdha273 ill let the engineering team know you are awaiting a response |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
discord username: mugdha4791
…On Tue, 9 Apr, 2024, 1:42 am Vincent (Wen Yu) Ge, ***@***.***> wrote:
Hey there! There were a lot of big PRs during this Hacktoberfest, and we
wanted to give everyone ample time to collaborate with our engineering
team. If you were able to merge your PRs during October, amazing. If it’s
still not merged, don’t worry about it either. Either way, we’ve got your
Hacktoberfest swag minted and ready to ship.
Please comment with your Discord username here so we can contact you about
your shipping information to deliver your Hacktoberfest swag.
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUI3Z7RMZN4IX4KM6ZFZMXLY4L2Z3AVCNFSM6AAAAAA5PNBGCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGU2TSNJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closes #6410
Here are the test results attached to it