Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: getSuffix() empty for some domains #22

Closed
2 tasks done
fadedshadowx opened this issue Dec 14, 2022 · 0 comments · Fixed by #29
Closed
2 tasks done

🐛 Bug Report: getSuffix() empty for some domains #22

fadedshadowx opened this issue Dec 14, 2022 · 0 comments · Fixed by #29
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fadedshadowx
Copy link

👟 Reproduction steps

This occurs for domains with * in the suffix list: https://publicsuffix.org/list/public_suffix_list.dat
for example:

$domain = new Domain('example.com.jm');
$domain->getSuffix();

👍 Expected behavior

"com.jm"

👎 Actual Behavior

"" (empty)

🎲 Utopia Domain version

Version 0.2.x

💻 Operating system

Linux

🐘 PHP Version

PHP 7.4.x

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@fadedshadowx fadedshadowx added the bug Something isn't working label Dec 14, 2022
@stnguyen90 stnguyen90 changed the title 🐛 Bug Report: 🐛 Bug Report: getSuffix() empty for some domains Dec 14, 2022
@stnguyen90 stnguyen90 added the good first issue Good for newcomers label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants