-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat query gen 2.3 #163
Merged
Merged
Feat query gen 2.3 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-query-gen-2.1
Feat: Improved performance
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
from
August 9, 2022 23:19
db04fbe
to
e48bdaa
Compare
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
from
August 11, 2022 01:03
39e3e89
to
478098a
Compare
fogelito
reviewed
Aug 11, 2022
eldadfux
requested changes
Aug 11, 2022
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
from
August 11, 2022 20:48
478098a
to
4811845
Compare
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
2 times, most recently
from
August 12, 2022 21:12
ab84f65
to
6dd00dd
Compare
eldadfux
requested changes
Aug 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, I think we should be close to a merge :)
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
from
August 13, 2022 22:26
6dd00dd
to
d6ba28d
Compare
eldadfux
reviewed
Aug 14, 2022
Query matches the naming convention of the other validators. We can use aliasing whenever any conflict arises with Utopia\Database\Query.
stnguyen90
force-pushed
the
feat-query-gen-2.3
branch
from
August 14, 2022 07:52
d6ba28d
to
d5de1d6
Compare
eldadfux
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on previous feedback:
This PR updates the Query class to be used like:
Update parsing of queries to be like:
In addition, this PR updates the Database find methods to only use queries (the Adapter's find method remains the same).
Finally, this PR also updates the Queries Validator to validate limit, offset, cursor, and order queries.