Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET/POST リクエストの書き直し #835

Merged
merged 24 commits into from
Sep 29, 2024
Merged

GET/POST リクエストの書き直し #835

merged 24 commits into from
Sep 29, 2024

Conversation

aster-void
Copy link
Contributor

@aster-void aster-void commented Sep 22, 2024 •
edited
Loading

closes #816

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 22, 2024 •
edited
Loading

Deploying utcode-learn with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc2772f
Status: ✅  Deploy successful!
Preview URL: https://97a6cca9.utcode-learn.pages.dev
Branch Preview URL: https://fix-get-post.utcode-learn.pages.dev

View logs

@aster-void aster-void marked this pull request as ready for review September 22, 2024 13:53
chelproc
chelproc reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@chelproc chelproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動画の解像度が低すぎる気がします。

あとはリクエストとレスポンスの図は入れたいですね、、、
POSTリクエストでもブラウザは画面遷移することは知っておいて欲しいところ

docs/3-web-servers/07-get-post/method-region.drawio.svg Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
@aster-void
Copy link
Contributor Author

aster-void commented Sep 23, 2024 •
edited
Loading

動画の解像度は自分のノートだとどうしようもなかったです (そもそもの解像度が低い)
-> ずっと解像度低い状態で生活してた... そのうちとりなおします

@chvmvd
Copy link
Contributor

chvmvd commented Sep 27, 2024

Issueの方も書いていただけるとレビューを行いやすいです🙇
それぞれを変更することにした経緯がわからないので。

chvmvd
chvmvd reviewed Sep 28, 2024
View reviewed changes
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-get-post/index.mdx Outdated Show resolved Hide resolved
@chvmvd chvmvd merged commit 45868bc into main Sep 29, 2024
3 checks passed
@chvmvd chvmvd deleted the fix-get-post branch September 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvmvd chvmvd chvmvd approved these changes

@chelproc chelproc chelproc approved these changes

@naka-12 naka-12 Awaiting requested review from naka-12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET/POST の章を大きく変更する
4 participants
@aster-void @chvmvd @chelproc @naka-12