Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザー名検索 #524

Merged
merged 14 commits into from
Dec 3, 2024
Merged

ユーザー名検索 #524

merged 14 commits into from
Dec 3, 2024

Conversation

RRRyoma
Copy link
Contributor

@RRRyoma RRRyoma commented Nov 10, 2024

PRの概要

検索機能(現在は、ユーザー名のみの部分一致検索)

具体的な変更内容

影響範囲

searchタブ内

動作

2024-12-02.20.56.09.mov

レビューリクエストを出す前にチェック!

  • [ ✓] 改めてセルフレビューしたか
  • [ ✓] 手動での動作検証を行ったか
  • server の機能追加ならば、テストを書いたか
    • 理由: 書いた | server の機能追加ではない
  • 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
    • 理由: 書いた | 間違った使い方は存在しない
  • わかりやすいPRになっているか

web/app/search/page.tsx Outdated Show resolved Hide resolved
web/app/search/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@KaichiManabe KaichiManabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

早めにマージしときたかったので、巻き取っときました!
変更点としては、検索の方法をqueryを使うことで、毎回クリックしなくても済むようにしました!

Copy link
Contributor

@KaichiManabe KaichiManabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaichiManabe KaichiManabe merged commit 4c60edc into main Dec 3, 2024
8 checks passed
@KaichiManabe KaichiManabe deleted the search branch December 3, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants