New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare-deploy-server を修正 #505

Merged

aster-void merged 3 commits into main from fix-prepare-deploy-server

Nov 1, 2024

Contributor

aster-void commented Oct 22, 2024 •

edited

Loading

PRの概要

具体的な変更内容

影響範囲

動作要件

補足

レビューリクエストを出す前にチェック！

改めてセルフレビューしたか
手動での動作検証を行ったか
server の機能追加ならば、テストを書いたか
- 理由: 書いた | server の機能追加ではない
間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
- 理由: 書いた | 間違った使い方は存在しない
わかりやすいPRになっているか

aster-void added 3 commits

October 22, 2024 21:25


          fix prepare deploy server


          fix it

fb53b43


          fix again

3ab196a

aster-void assigned naka-12 and KaichiManabe and unassigned naka-12 and KaichiManabe

aster-void requested review from naka-12 and KaichiManabe

October 27, 2024 11:33

naka-12 approved these changes

View reviewed changes

Contributor

naka-12 left a comment

LGTM

aster-void merged commit 6a4fe05 into main

7 checks passed

aster-void deleted the fix-prepare-deploy-server branch

November 1, 2024 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet