Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting 画面のスタイルを修正 #437

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Setting 画面のスタイルを修正 #437

merged 9 commits into from
Oct 8, 2024

Conversation

naka-12
Copy link
Contributor

@naka-12 naka-12 commented Oct 8, 2024

PRの概要

  • Setting 画面の上部のナビゲーションを共通化した。
  • 「あなたのカード」画面の構成を修正した。

具体的な変更内容

image

影響範囲

Setting 画面。

動作要件

補足

レビューリクエストを出す前にチェック!

  • 改めてセルフレビューしたか
  • 手動での動作検証を行ったか
  • server の機能追加ならば、テストを書いたか
    • 理由: 書いた | server の機能追加ではない
  • 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
    • 理由: 書いた | 間違った使い方は存在しない
  • わかりやすいPRになっているか

@naka-12 naka-12 marked this pull request as ready for review October 8, 2024 07:36
@naka-12 naka-12 requested a review from KaichiManabe October 8, 2024 07:42
Copy link
Contributor

@KaichiManabe KaichiManabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaichiManabe KaichiManabe merged commit 375fc84 into main Oct 8, 2024
7 checks passed
@KaichiManabe KaichiManabe deleted the fix-436 branch October 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting画面のあなたのカード画面の見た目が微妙
2 participants