Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm packages #193

Open
annez opened this issue Oct 7, 2016 · 5 comments
Open

Upgrade npm packages #193

annez opened this issue Oct 7, 2016 · 5 comments
Assignees

Comments

@annez
Copy link
Contributor

annez commented Oct 7, 2016

Grunt is now at 1.0.0 and a lot of our packages are out of date. We should take a look and upgrade them.

  • scss-lint
  • stylestats
  • cssstats
  • jscs
  • sassdoc

Are all important to our development and should be upgraded.

@jpstevens jpstevens self-assigned this Oct 31, 2016
@jpstevens
Copy link
Contributor

@annez RE "should be upgraded", can you give reasons?

@annez annez added the bug label Oct 31, 2016
@annez
Copy link
Contributor Author

annez commented Oct 31, 2016

Yes, most of these packages were never in a stable release so they've been constantly upgraded and improved

  • scss-lint has added more features for future CSS, plus plenty of bug fixes
  • cssstats is giving out more detailed and easier to digest stats in the latest versions
  • same applies to stylestats, both which we should be more prominently using to understand our CSS complexity and size (or not, depending on the performance argument nowadays)
  • sassdoc has added some description features (nothing major) http://sassdoc.com/customising-the-view/#description

With grunt and the watch tasks - they no longer work as expected and it seems you need to save .scss files twice to get the right compilation. This is probably a dependency issue around Node 4+ and old version of file watcher and grunt.

Get the error:

Fatal error: this.ee._events.hasOwnProperty is not a function

Every time we run the watcher task

image

@theinternetofthinks
Copy link

Hi, and what can I do for solve the problem? I have updated the packages and it doesn't work

@annez
Copy link
Contributor Author

annez commented Apr 23, 2017

Hi @marcosefrem - can you show us a diff of the packages you updated and a stack trace of what is erroring?

@theinternetofthinks
Copy link

Here you have, thanks in advance

packages
error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants