Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename semver compare function #4

Closed
wendellpiez opened this issue Mar 15, 2023 · 1 comment · Fixed by #6
Closed

Rename semver compare function #4

wendellpiez opened this issue Mar 15, 2023 · 1 comment · Fixed by #6
Assignees

Comments

@wendellpiez
Copy link
Collaborator

As discussed in #3, now the namespace identifying functions serves across the repository, the name compare for the semantic versioning comparison function is too broad.

We agreed on semver-compare as the best balance between clarify and succinctness.

AC (please edit)

  • the function is renamed
  • any docs are changed accordingly

Dependency: some due diligence regarding if/where we use the function. Note: any callers have to change the namespace as well.

@galtm
Copy link
Collaborator

galtm commented Mar 16, 2023

@wendellpiez or @aj-stein-nist : You can assign this to me. I can fix it in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants