Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GitHub Actions Installs Python Dependencies Like Local Docker Environment #103

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented May 4, 2022

Committer Notes

This resolves misalignment between the local developer env for Docker and the managed GitHub Actions for runners where the latter did not install necessary deps for the content conversion script written in Python.

This will close usnistgov/OSCAL#1216 for short-term bug fixing, and long-term improvements will be continued in subsequent systemic improvements tracked in other issues cited in the comment.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist force-pushed the issue-1216-align-actions-docker-python-deps branch 2 times, most recently from f8ae6ea to 17ae2d9 Compare May 4, 2022 02:00
@aj-stein-nist aj-stein-nist added the Scope: CI/CD A task issue to modify the repo's continuous integration and continuous deployment capability. label May 4, 2022
@aj-stein-nist aj-stein-nist self-assigned this May 4, 2022
@aj-stein-nist aj-stein-nist marked this pull request as ready for review May 4, 2022 02:00
@aj-stein-nist
Copy link
Contributor Author

aj-stein-nist commented May 4, 2022

@david-waltermire-nist I hit some silly hiccups but this is ready to review. IMPORTANT: this took me a long time to realize, but the requirements.txt file was missing because I forgot to bring up the OSCAL repo in the submodule at ./oscal from around v1.0.0 to v1.0.2 and included this in the PR as necessary. We should have caught this prior, and had not done so yet, and seems likely minor?

@wesley-dean-gsa, can't add you as a formal reviewer. This is as the short-term quick fix for usnistgov/OSCAL#1216 before we move onto longer term enhancements.

Also, remove dead code for unused SSH deployment post-refactors from
before.
@aj-stein-nist aj-stein-nist force-pushed the issue-1216-align-actions-docker-python-deps branch from 1bb667a to be66460 Compare May 4, 2022 16:00
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@david-waltermire david-waltermire merged commit eeaf7eb into usnistgov:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: CI/CD A task issue to modify the repo's continuous integration and continuous deployment capability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt not loaded outside of Docker context
2 participants