Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round Trip Content Conversion Not Run in GHA CI/CD #115

Open
aj-stein-nist opened this issue Jul 11, 2022 · 1 comment
Open

Round Trip Content Conversion Not Run in GHA CI/CD #115

aj-stein-nist opened this issue Jul 11, 2022 · 1 comment
Assignees
Labels
bug The issue is a bug report. Discussion Needed The issue or PR needs to be reviewed by the OSCAL development team. question The issue contains a question that needs to be answered.

Comments

@aj-stein-nist
Copy link
Contributor

Describe the bug

In the course of completing usnistgov/OSCAL#1222, review of the current CI/CD documentation indicates we did or currently do intend to run validate-content-conversion-round-trips.sh, either with run-all.sh as code or as wording suggests independently. The former is not implemented and the latter is currently commented out. Documentation should be updated or pipelines ought to be updated at a later date. This bug was opened to solicit feedback from project leads and development team.

Who is the bug affecting?

Developers who want to modify and test the consistency of round-tripped OSCAL document instances from any combination JSON, XML, and YAML.

What is affected by this bug?

Testing of round-tripping of content conversion.

When does this occur?

Consistently in our hosted CI/CD system, partially works with custom tweaks to shell scripting run-all.sh to restore back round-trip testing of content conversion.

How do we replicate the issue?

1a. Execute GitHub Actions through CI/CD and review output in debugging mode.
1b. Execute bash -x ./build/ci-cd/run-all.sh in local testing environment and observe debug output

Expected behavior (i.e. solution)

Updated documentation or updated pipelines actually testing round tripping functionality.

Other Comments

N/A

@aj-stein-nist aj-stein-nist added bug The issue is a bug report. question The issue contains a question that needs to be answered. Discussion Needed The issue or PR needs to be reviewed by the OSCAL development team. labels Jul 11, 2022
@david-waltermire david-waltermire transferred this issue from usnistgov/OSCAL Jul 12, 2022
@aj-stein-nist
Copy link
Contributor Author

aj-stein-nist commented Jul 12, 2022

I talked with Dave and Wendell, and they agree that full round-trip test integration in CI/CD with a neat, clean pass or fail result is complex at this time. Wendell made some good points re the complexities of round-tripping specific fields in JSON/XML/YAML, like any those with a Markdown-ish type of markup-multiline and different implementations. Re the recommended path forward, we agreed given the conversation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug report. Discussion Needed The issue or PR needs to be reviewed by the OSCAL development team. question The issue contains a question that needs to be answered.
Projects
Status: Further Analysis Needed
Development

No branches or pull requests

1 participant