Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to XSpec reporting under CI #99

Conversation

wendellpiez
Copy link
Collaborator

Includes a few corrections to tests and settings towards full functioning of XSpec reports published in CI/CD.

Committer Notes

Check out the Files Changed, the list should be short and self-explanatory.

Also happy to rebase this branch as necessary.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@wendellpiez wendellpiez requested a review from a team as a code owner February 6, 2024 22:55
@aj-stein-nist
Copy link
Contributor

We can see the output with test metrics here, @wendellpiez.

https://github.com/usnistgov/metaschema-xslt/actions/runs/7932152044

I am not sure why it doesn't comment on the PR anymore, but I will look into that. But give me a few minutes on that.

@aj-stein-nist aj-stein-nist force-pushed the issue98-feature-XSLT-inspectorB branch from 98f41f8 to b345a0e Compare February 16, 2024 16:16
@aj-stein-nist aj-stein-nist force-pushed the issue98-feature-XSLT-inspectorB branch from b345a0e to 35629a1 Compare February 16, 2024 16:19
@aj-stein-nist
Copy link
Contributor

@wendellpiez you will need to merge this to your default branch (judging from your set up that is when you visit this repo directly in a browser and what is specified in the settings for it completely work, but it has been simulated and test in the closed PR before after I merged it into develop and main in my fork (I am not sure I have it set up the same so did both to be careful) and intentionally borked a test in the PR.

aj-stein-nist#1

So this feature branch (the target of this PR) goes into develop, you should be ready to go.

@aj-stein-nist aj-stein-nist merged commit 00c5732 into usnistgov:feature-InspectorXSLT Feb 16, 2024
2 checks passed
aj-stein-nist added a commit that referenced this pull request Feb 16, 2024
* Metaschema XSLT Inspector (#73)

Several months of work building InspectorXSLT using test-driven-development.
Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support.

---------

Co-authored-by: A.J. Stein <[email protected]>

* Update XSPEC-BATCH.xsl

On-the-fly modification of JUnit XML results

* Adjustments to XSpec reporting under CI (#99)

* Fine adjustments in prep for 'nearly good enough' XSpec support under ci/cd (in feature branch)

* Adjustments for legibility

* Another touchup

* Buffs in view of CI/CD and local/CL use cases for testing under make including new error-on-fail option

* Added to script documentation

* Still polishing help msg

* Now with some more nicer XProc and scripting supporting ongoing maintenance / dev

* adjustments to test runtime

* Further refinements to testing & scripts

* Rationalizing including file name regularization

* Further configuration enhancements

* More help in docs

* Further testing/tuning/tweaking test runtimes and docs

* Further alignment

* New 'quiet' XSpec batching script, plus adjustment

* New 'make' feature for testing InspectorXSLT

* More Makefile edits / cleanup

* Further docs and readme improvements

* Removed obsolete Schematron implementation, no longer of interest

* More polishing

* Further small but useful improvements and cleanup

* Added another utility script

* Continuing to touch up

* Add permissions for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:

https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Add artifact event pull for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:

https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Ensure XSpec test results comment always made on PR

* [WIP] Dedupe event trigger and inline JUnit XML processing in CI workflow

---------

Co-authored-by: A.J. Stein <[email protected]>

---------

Co-authored-by: A.J. Stein <[email protected]>
wendellpiez added a commit to wendellpiez/metaschema-xslt that referenced this pull request Jun 6, 2024
*** Many improvements to XSLTs and XSpec reporting scripts

* Add permissions for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:
https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Add artifact event pull for EnricoMi/publish-unit-test-result-action

Using the guidance from the action's instructions:

https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches

* Ensure XSpec test results comment always made on PR
* [WIP] Dedupe event trigger and inline JUnit XML processing in CI workflow

---------

Co-authored-by: A.J. Stein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants