Schema links for validation are broken.

[Compton-US]

Describe the bug

I noticed that the references to the schematron files and metaschema.xsd pointed to the old metaschema submodule instead of the new metaschema-xslt. This resulted in validations passing when there were possible issues in metaschema documents.

Who is the bug affecting

All developers, and ultimately the schemas and converters in OSCAL.

What is affected by this bug

Modeling, Tooling & API

How do we replicate this issue

See the following references for an example:

• OSCAL/src/metaschema/oscal_component_metaschema.xml

  Line 2 in ef4df06

  <?xml-model href="../../build/metaschema/toolchains/xslt-M4/validate/metaschema-composition-check.sch" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>

• OSCAL/src/metaschema/oscal_component_metaschema.xml

  Line 15 in ef4df06

  xmlns="http://csrc.nist.gov/ns/oscal/metaschema/1.0" xsi:schemaLocation="http://csrc.nist.gov/ns/oscal/metaschema/1.0 ../../build/metaschema/toolchains/xslt-M4/validate/metaschema.xsd">

Expected behavior (i.e. solution)

Validations should fail when problems are encountered in documents.

Other comments

I already have a PR ready to push. Will push shortly for review.

Revisions

No response

[nikitawootten-nist]

#1872 fixes this (but will likely not be merged soon), should I break out 0c7d1eb into its own PR?

[Compton-US]

@nikitawootten-nist the PR I just pushed covers the broken xml-model references too.

https://github.com/usnistgov/OSCAL/pull/1884/files

[Compton-US]

Also for awareness, in CI, if there are errors in metaschema, then validation might still pass in some cases. May need to prioritize this.

[aj-stein-nist]

Quickly discussed this in issue review today and we need to make sure we prioritize this correctly especially if we are not making a release in the near future. The work itself is complete and this issue may be closed.