Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link "Resend verification email" is displayed even if require_email_verification = false #815

Closed
centauromax opened this issue Nov 18, 2017 · 2 comments
Labels
frontend The frontend interface
Milestone

Comments

@centauromax
Copy link

Hi,
in the login form, the link "Resend verification email" is displayed even if site.registration.require_email_verification = false.

Where is the problem:

In the template userfrosting/app/sprinkles/account/templates/pages/sign-in.html.twig, the link is displayed without checking the value of the flag:

        <a href="{{site.uri.public}}/account/resend-verification">{{translate('ACCOUNT.VERIFICATION.RESEND')}}</a><br>
        {% if site.registration.enabled %}
            <a href="{{site.uri.public}}/account/register">{{translate('REGISTER')}}</a>
        {% endif %}
@alexweissman alexweissman added this to the v4.1.13 milestone Nov 18, 2017
@alexweissman alexweissman added the frontend The frontend interface label Nov 18, 2017
@alexweissman
Copy link
Member

alexweissman commented Dec 13, 2017

Actually, there is a use case where you'd want to still display this link, even if site.registration.require_email_verification = false. This is the case where you turn off require_email_verification while there are still outstanding unverified users.

I guess the best thing to do, is check the value of site.registration.require_email_verification during authentication and ignore the user's verification status if it is set to false.

@alexweissman
Copy link
Member

Ok, this is fixed in v4.1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The frontend interface
Projects
None yet
Development

No branches or pull requests

2 participants