Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically invoke Sprinkle service provider #636

Closed
lcharette opened this issue Feb 3, 2017 · 5 comments
Closed

Automatically invoke Sprinkle service provider #636

lcharette opened this issue Feb 3, 2017 · 5 comments
Assignees
@alexweissman
Labels
todo Generic task
Milestone
4.1.0

Comments

@lcharette
Copy link
Member

As discussed on the chat.
@lcharette lcharette added todo Generic task V4 labels Feb 3, 2017
@alexweissman
Copy link
Member

I wonder...can we sneak this into v4? Would it be BC? What happens if you call register twice on a service provider class?

@Silic0nS0ldier
Copy link
Member

@alexweissman Calling register twice was happening in the migrations before. Made core act a little... odd.

@lcharette
Copy link
Member Author

Could be something else than registering twice? My middleware was loaded along side it's service provider no problem?

@alexweissman alexweissman added this to the 4.0 under consideration milestone Mar 1, 2017
@alexweissman alexweissman self-assigned this Mar 20, 2017
@alexweissman alexweissman modified the milestones: 4.1, 4.0 under consideration Apr 4, 2017
@alexweissman
Copy link
Member

Ok, this will be implemented in the upcoming version 4.1.

@alexweissman
Copy link
Member

Implemented in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexweissman alexweissman

Labels
todo Generic task
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
3 participants
@lcharette @alexweissman @Silic0nS0ldier