-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube-local doesn't work for some videos, mainly music videos #218
Comments
Hi, I encountered similar problem and prepared a few changes in the Let me know if my changes solve this issue. |
@alive4ever Yes, your changes solved it. Thanks. |
another confirmation your changes solve the music vid problem, thank you very much. for those on windows who are building themselves, note that fake-useragent (a new dependency introduced in this fix) doesn't seem to work properly with how this tool is built. In the thanks again |
Hi, sorry for the inconvenience. I don't test the python3.11 -m venv --upgrade-deps venv
pip install -r requirements.txt
source ./venv/bin/activate
python ./server.py Currently doing a trial build to run As for playlist page problem, I don't have a clue since I am focusing on the watch page, especially player extraction from yt-api response. |
Hi, after several attempts of github actions, a release is possible without those changes (winehq stable, python 3.11.9). Look at releases section of my repo The only required change is modifying branch name from diff --git a/generate_release.py b/generate_release.py
index aed9d22..36d368b 100644
--- a/generate_release.py
+++ b/generate_release.py
@@ -92,7 +92,7 @@ if os.path.exists('./youtube-local'):
# confused with working directory. I'm calling it the same thing so it will
# have that name when extracted from the final release zip archive)
log('Making copy of youtube-local files')
-check(os.system('git archive --format tar master | 7z x -si -ttar -oyoutube-local'))
+check(os.system('git archive --format tar HEAD | 7z x -si -ttar -oyoutube-local'))
if len(os.listdir('./youtube-local')) == 0:
raise Exception('Failed to copy youtube-local files') |
So I tested my own github action build and found that the issue is during runtime, not during build. Sorry for my ignorance in the previous reply. I've added a commit in my pull-request to modify |
Trying to open https://www.youtube.com/watch?v=kJQP7kiw5Fk for example, gives this error:
The text was updated successfully, but these errors were encountered: