Add E2E Mutation tests for Lagu #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhorky
changed the title
Schnitzel
approved these changes
Jul 30, 2018
…to add-e2e-mutation-tests-for-cli
Schnitzel
added a commit
that referenced
this pull request
Jul 31, 2018
Add E2E Mutation tests for Lagu
|
merged into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on the work done in #430 to write end to end tests for lagu that test the commands that execute mutations.
❗️Should probably merge #430 and then set the base branch of this PR to
masterbefore merging this one.TODO
lagu project deletecommandlagu project createlagu project deletelagu projectsoutputRef: https://github.com/amazeeio/lagoon/blob/52a42dd55145b2e56c4b23e226bc8cd6c27f2f93/cli/src/__tests__/__snapshots__/e2e.test.js.snap#L95
Ref: https://github.com/amazeeio/lagoon/blob/52a42dd55145b2e56c4b23e226bc8cd6c27f2f93/cli/src/__tests__/__snapshots__/e2e.test.js.snap#L136
Ref: child_process stdout being truncated nodejs/node#19218
Ref: maxBuffer isn't working sindresorhus/execa#130)
Closes #498