Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually throw error in environmentExists if the environment doesn't exist #3734

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: actually throw error in environmentExists if the environment doesn't exist #3734

merged 1 commit into from
Jun 7, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Fix the environment exists validator check to actually throw the error if the environment doesn't exist.

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jun 6, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review June 7, 2024 00:01
tobybellwood
tobybellwood approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough change, nice and easy

@tobybellwood tobybellwood merged commit 8ef9eac into main Jun 7, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the environment-exists-validator branch June 7, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood