Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: send organization information in build and task payloads #3596

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Nov 14, 2023

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Update the build and task data payloads to inject the organization name and ID if they are present on a project.

Closing issues

partially #3595

@shreddedbacon shreddedbacon marked this pull request as ready for review November 15, 2023 02:02
@shreddedbacon shreddedbacon changed the title refactor: send organization information in build payload refactor: send organization information in build and task payloads Nov 15, 2023
@tobybellwood tobybellwood added this to the 2.17.0 milestone Dec 11, 2023
@tobybellwood
Copy link
Member

Comparing the payloads:

builds:

      "project":{
         "id":18,
         "name":"lagoon-demo-org",
         "organization":{
            "name":"lagoon-demo-organization",
            "id":1
         },
         ...
      "project":{
         "id":18,
         "name":"lagoon-demo",
         "organization":{
            
         },

and tasks:

   "project":{
      "id":180,
      "name":"lagoon-demo-org",
      "organization":{
         "name":"lagoon-demo-organization",
         "id":1
      },
      ...
   "project":{
      "id":18,
      "name":"lagoon-demo",
      "organization":null,

Is there a reason why tasks shouldn't be an empty object (or builds null) - just checking on the inconsistency

@shreddedbacon
Copy link
Member Author

Is there a reason why tasks shouldn't be an empty object (or builds null) - just checking on the inconsistency

I've updated it so the two results are null if no organization

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, confirmed payload success locally.

@tobybellwood tobybellwood merged commit ad7c67d into main Dec 12, 2023
1 check passed
@tobybellwood tobybellwood deleted the organization-build-data branch December 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants