Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent adding same SSH key multiple times #577

Closed
Schnitzel opened this issue Aug 17, 2018 · 2 comments · Fixed by #959
Closed

Prevent adding same SSH key multiple times #577

Schnitzel opened this issue Aug 17, 2018 · 2 comments · Fixed by #959
Assignees
@Schnitzel
Labels
1-api-auth API & Authentication subsystem priority-high

Comments

@Schnitzel
Copy link
Contributor

Describe the bug
It is possible to add the same SSH key multiple times via the GraphQL API

To Reproduce
Steps to reproduce the behavior:

  1. Add any SSH Key via addSshKey() mutation
  2. Add it a second time, still works

Expected behavior
It should throw an error that the key already exists
@Schnitzel Schnitzel added the 1-api-auth API & Authentication subsystem label Aug 17, 2018
@Schnitzel
Copy link
Contributor Author

I think this has been fixed

@Schnitzel Schnitzel reopened this Mar 8, 2019
@Schnitzel
Copy link
Contributor Author

Looks like this is not fixed :(
And it causes all kind of issues.

@rocketeerbkw rocketeerbkw mentioned this issue Mar 11, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Schnitzel Schnitzel

Labels
1-api-auth API & Authentication subsystem priority-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: Disallow duplicate ssh keys uselagoon/lagoon
3 participants
@rocketeerbkw @Schnitzel @nicolerdeangelis