Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cronjob names are unique #272

Open
seanhamlin opened this issue Nov 27, 2023 · 1 comment
Open

Ensure cronjob names are unique #272

seanhamlin opened this issue Nov 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@seanhamlin
Copy link
Contributor

At present, it is possible to define 2 cronjobs in .lagoon.yml with the same name.

      - name: test-cronjobs
        schedule: "M * * * *"
        command: /app/console do:stuff
        service: cli
      - name: test-cronjobs
        schedule: "M * * * *"
        command: /app/console do:something:different
        service: cli

Only the last one will 'win', and only a single cronjob will be made. This is confusing for the end user.

Proposed solution

Either pass the build with warnings, or fail the build entirely. Either way, we should inform the use that they need to adjust their .lagoon.yml file.

@seanhamlin seanhamlin added the enhancement New feature or request label Nov 27, 2023
@shreddedbacon
Copy link
Member

I think failure would be better, as long as the failure can happen early

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants