Fix: Docs Pane Doesn't Save Changes with Ctrl+S (Cmd+S on Mac) in Preview Mode (Updated PR: #2297) #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per discussion with @Pragadesh-45 , we decided that a better approach would be to have the save hotkey listener apply to the entire collection settings tab. He will be working on this on a separate PR. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2219
This PR resolves the issue preventing docs from being saved in preview mode. Users can now save their docs in both edit and preview modes. It updates the implementation from PR #2297 , which used a deprecated method for handling the save function. I have made contributions to improve the same implementation.
Contribution Checklist: