[Feature] : Bulk env import and UX/UI improvements #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 24, 2024 15:43
…al, UI improvements
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
* feat(bulk-env-import): bulk import working like a charm * feat(bulk-env-import): refresh no env dialog's styling * feat(bulk-env-import): group create and import env within initial modal, UI improvements * feat(bulk-env-import): minor styling fixes * feat(bulk-env-import): handle incorrect files in env importer --------- Co-authored-by: bpoulaindev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue #2473
Rendering a modal on top of a modal is not a good practice
This PR introduces :
New "no env" modal :
Create env in the same modal level :
Same for import env + styling :
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.