fix: Collection variable viewer #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes in usebruno#650 collection variables would be passed as a object but was exptected to be an array. Collection variables are now converted to an array.
5 tasks
sanjai0py
approved these changes
Apr 5, 2024
|
I tested locally this bugfix it works, could it be merged please ? |
|
Merged! Thank you @Its-treason ! This will go out in the |
slowjoe007
pushed a commit
to slowjoe007/bruno
that referenced
this pull request
Apr 10, 2024
Due to changes in usebruno#650 collection variables would be passed as a object but was exptected to be an array. Collection variables are now converted to an array.
lizziemac
pushed a commit
to lizziemac/bruno
that referenced
this pull request
May 4, 2024
Due to changes in usebruno#650 collection variables would be passed as a object but was exptected to be an array. Collection variables are now converted to an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in #650 collection variables would be passed as an object but were expected to be an array. Collection variables are now converted to an array.
Fixes: #1940
Also, we should later remove the
Show secret variable valuesbutton for Collection.