Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Collection settings: unsaved changes are not recognized properly #2219

Closed
2 tasks done
tho-gru-38 opened this issue May 2, 2024 · 1 comment · Fixed by #3145
Closed
2 tasks done

[Bug] Collection settings: unsaved changes are not recognized properly #2219

tho-gru-38 opened this issue May 2, 2024 · 1 comment · Fixed by #3145
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tho-gru-38
Copy link

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

Hi,

Edit the Docs of a collection. Switch to a request of the collection or even to a new tab (e.g. Info) in the collection settings.

The Docs pane will be switched into "Preview" when next clicking on it. In this situation the save (CTRL-S) does not save the changed Docs. When exiting Bruno the change of Docs at collection level is not recognized and therefore lost.

The only chance to save changes of the Docs at collection level is to press CTRL-S before clicking elsewhere in Bruno.

Kind Regards
Thomas

PS: While creating the screen shots for this issue I recognized that there will no pop up when exiting Bruno after I changed some script of the collection

.bru file to reproduce the bug

No response

Screenshots/Live demo link

  1. step - Add some new text in the Docs:
    image

  2. step - Switch to the Info tab:
    image

  3. step - Switch back to the Docs tab:
    image
    The newly entered Text is still present (but unsaved).

  4. step - Type CTRL-S
    nothing visible in this step - no "Collection Setting saved successfully" toast displayed

  5. step - exit Bruno
    nothing visible in this step - no pop up like:
    image

  6. Step - Start Bruno, look at the Docs of the settings
    image
    The new text is gone :-(

@tho-gru-38 tho-gru-38 added the bug Something isn't working label May 2, 2024
@tho-gru-38 tho-gru-38 changed the title [Bug] Docs at Collection level: unsaved changes are not recognized properly [Bug] Collection settings: unsaved changes are not recognized properly May 2, 2024
@sanjai0py sanjai0py added the good first issue Good for newcomers label May 8, 2024
@tho-gru-38
Copy link
Author

#2169 will be obsolete, if this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment