Release v4.0.1
#1688
Release v4.0.1
#1688
Conversation
SkymanOne
requested review from
cmichi,
ascjones and
HCastano
as code owners
Co-authored-by: Michael Müller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
==========================================
- Coverage 70.77% 70.68% -0.10%
==========================================
Files 206 206
Lines 6416 6416
==========================================
- Hits 4541 4535 -6
- Misses 1875 1881 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| contract-metadata = { version = "2.0.0-rc.1" } | ||
| contract-metadata = { version = "2.0.0" } |
There was a problem hiding this comment.
❤️ Might be worth mentioning this "fix" in the RELEASENOTES
| @@ -178,8 +179,7 @@ mod flipper { | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| The [`flipper/src/lib.rs`](https://github.com/paritytech/ink-examples/blob/v4.0.0/flipper/lib.rs) | |||
| The [`flipper/src/lib.rs`](https://github.com/paritytech/ink-examples/blob/v4.0.1/flipper/lib.rs) | |||
There was a problem hiding this comment.
Is there the need to create a new tag for this in the ink-examples? The 4.0.0 examples should still be compatible, otherwise it wouldn't be able to be a patch release in the first place.
But perhaps it is just easier to create tag per release regardless.
Also we need to add a step to the release checklist for creating this branch where required.
There was a problem hiding this comment.
Is there the need to create a new tag for this in the
ink-examples? The4.0.0examples should still be compatible, otherwise it wouldn't be able to be a patch release in the first place.But perhaps it is just easier to create tag per release regardless.
Also we need to add a step to the release checklist for creating this branch where required.
I reckon there is nothing wrong to indicate the latest version in examples.
Changelog
Introduces a small bug fix.
Fixed
ManualKey<0>to act properly - #1670