Add set_code_hash function and example
#1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willser
requested review from
Robbepop,
cmichi,
ascjones and
HCastano
as code owners
willser
force-pushed
the
will/add-seal_set_code_hash-function-and-example
branch
from
07be2d5
to
b3bf653
Compare
|
Hello team,I checked the CI log and got thoese information.It's that something wrong in this PR? $ git clone --verbose --depth 1 --branch ${UPSTREAM_BRANCH} ${UPSTREAM_REPO}
Cloning into 'ink'...
warning: Could not find remote branch will/add-seal_set_code_hash-function-and-example to clone.
fatal: Remote branch will/add-seal_set_code_hash-function-and-example not found in upstream originUPSTREAM_BRANCH_REDIS_KEY=will-add-seal_set_code_hash-function-and-example
$ echo "UPSTREAM_REPO=${UPSTREAM_REPO}" | tee -a parent-vars.env
UPSTREAM_REPO=https://github.com/paritytech/ink.git
$ echo "UPSTREAM_REPO_NAME=${UPSTREAM_REPO_NAME}" | tee -a parent-vars.env |
cmichi
reviewed
Apr 22, 2022
examples/upgradeable-contracts/set-code-hash/new-increamenter/lib.rs
Outdated
Show resolved
Hide resolved
examples/upgradeable-contracts/set-code-hash/new-increamenter/lib.rs
Outdated
Show resolved
Hide resolved
examples/upgradeable-contracts/set-code-hash/new-increamenter/lib.rs
Outdated
Show resolved
Hide resolved
examples/upgradeable-contracts/set-code-hash/new-increamenter/lib.rs
Outdated
Show resolved
Hide resolved
|
Thanks so much for implementing this @willser ! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ink_env::set_code_hashand create two examples inexamples/upgradeable-contracts/set-code-hash.Resolves #1185 .