Stop using CallData
in Multisig doc test
#1202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example we were providing in the
add_owner
documentation of the Multisig exampleused
CallData
, which is only available in the off-chain testing engine. This meant thatif contract authors used this example vertabim in their contracts (which is totally
reasonable in this case) their contracts wouldn't compile.
I've changed the example to use things that would be available to contract authors so
in order to make the example more copy-pastable.
Closes #1197 again 😅