Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up #665: Make ink! chain extensions use is_result_type! utility macro #952

Closed
Robbepop opened this issue Oct 6, 2021 · 1 comment · Fixed by #1569
Closed

Follow-up #665: Make ink! chain extensions use is_result_type! utility macro #952

Robbepop opened this issue Oct 6, 2021 · 1 comment · Fixed by #1569
Assignees
@SkymanOne
Labels
A-eDSL Concerning the Rust eDSL as a total. B-enhancement New feature or request

Comments

@Robbepop
Copy link
Collaborator

Robbepop commented Oct 6, 2021

The #665 PR introduces some new is_result_type! utility macro to check at compile time whether some type is a Result using the Rust type system.
This means that we can get rid of the returns_result: bool ink! attribute of ink! chain extensions since it is now possible to infer this information via the proc. macro itself.
@Robbepop Robbepop added A-eDSL Concerning the Rust eDSL as a total. B-enhancement New feature or request E-blocked The task is blocked on some other task to be finished. labels Oct 6, 2021
@HCastano
Copy link
Contributor

We should have this in for ink! 4.0 (#1343). @SkymanOne or @lean-apple this might be something for one of you to take on

@HCastano HCastano moved this to Backlog 🗒 in Smart Contracts Nov 23, 2022
@HCastano HCastano removed the E-blocked The task is blocked on some other task to be finished. label Nov 23, 2022
@SkymanOne SkymanOne self-assigned this Dec 12, 2022
@SkymanOne SkymanOne mentioned this issue Dec 24, 2022
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Backlog 🗒 to Done ✅ in Smart Contracts Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkymanOne SkymanOne

Labels
A-eDSL Concerning the Rust eDSL as a total. B-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chain Extension: Evaluation of method return type at compile time use-ink/ink
3 participants
@Robbepop @HCastano @SkymanOne