Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seal0 calls to seal1 #879

Closed
2 tasks
HCastano opened this issue Jul 26, 2021 · 0 comments · Fixed by #1053
Closed
2 tasks

Update seal0 calls to seal1 #879

HCastano opened this issue Jul 26, 2021 · 0 comments · Fixed by #1053
Assignees
@cmichi
Labels
A-ink_storage [ink_storage] Work Item good first issue Good for newcomers P-low Low priority issue.

Comments

@HCastano
Copy link
Contributor

HCastano commented Jul 26, 2021 •
edited by cmichi
Loading

Right now ink! is mainly using seal0 calls for interfacing with the contracts pallet.

However, there are a number of functions which have been updated to seal1, and whose seal0 implementations are deprecated (e.g seal_terminate).

We should make an effort to use seal1 calls where available. From what I can tell right now that means switching:
@HCastano HCastano added good first issue Good for newcomers A-ink_storage [ink_storage] Work Item P-low Low priority issue. labels Jul 26, 2021
@HCastano HCastano mentioned this issue Jul 26, 2021
Closed
@cmichi cmichi self-assigned this Oct 31, 2021
@cmichi cmichi mentioned this issue Nov 26, 2021
Merged
@cmichi cmichi moved this from Todo to In Progress in Production Smart Contracts Parachain Nov 26, 2021
Repository owner moved this from In Progress to Done in Production Smart Contracts Parachain Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmichi cmichi

Labels
A-ink_storage [ink_storage] Work Item good first issue Good for newcomers P-low Low priority issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade seal0 calls to seal1 use-ink/ink
2 participants
@cmichi @HCastano