Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of the Mapping's size method #1686

Closed
wottpal opened this issue Feb 24, 2023 · 4 comments · Fixed by #1735
Closed

Update documentation of the Mapping's size method #1686

wottpal opened this issue Feb 24, 2023 · 4 comments · Fixed by #1735
Labels
A-docs Task or issue concerning documentation

Comments

@wottpal
Copy link
Contributor

wottpal commented Feb 24, 2023

Currently, the documentation does not say which unit the return value has (it is bytes).

CC @cmichi

@HCastano
Copy link
Contributor

Can you open a PR for this?

@HCastano HCastano added the A-docs Task or issue concerning documentation label Feb 28, 2023
@wottpal
Copy link
Contributor Author

wottpal commented Feb 28, 2023

Yeah ofc. But never done rust/crate documentation before – It's just the comment/docstring above the function that needs to be changed, right?

1 similar comment
@wottpal
Copy link
Contributor Author

wottpal commented Feb 28, 2023

Yeah ofc. But never done rust/crate documentation before – It's just the comment/docstring above the function that needs to be changed, right?

@HCastano
Copy link
Contributor

HCastano commented Mar 1, 2023

Yep, that should be all. Here's some reference links for docs in Rust:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Task or issue concerning documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants