Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and refactor fallible constructors #1483

Closed
ascjones opened this issue Nov 8, 2022 · 0 comments · Fixed by #1491
Closed

Fix and refactor fallible constructors #1483

ascjones opened this issue Nov 8, 2022 · 0 comments · Fixed by #1491

Comments

@ascjones
Copy link
Collaborator

ascjones commented Nov 8, 2022

Following up on #1460, we should:

  1. Test whether this actually works either via a client (need to update e.g. cargo-contract to handle constructor return values), or a cross contract instantiation. See Generate metadata for constructor return type #1460 (comment). If it doesn't work we need to fix it.
  2. Refactor the metadata generation to see whether we can use fhe type system to generate the return type metadata. See Generate metadata for constructor return type #1460 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework fallible constructors use-ink/ink
1 participant
@ascjones