CI optimization #45
Merged
CI optimization #45
+56
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejparity
requested review from
ascjones,
cmichi,
rcny,
SkymanOne,
alvicsam,
altaua,
AndWeHaveAPlan and
mateo-moon
alvicsam
approved these changes
Oct 16, 2023
ascjones
reviewed
Oct 16, 2023
Comment on lines
+34
to
+61
| - basic-contract-caller | ||
| - call-runtime | ||
| - conditional-compilation | ||
| - contract-terminate | ||
| - custom-allocator | ||
| - custom-environment | ||
| - dns | ||
| - e2e-call-runtime | ||
| - erc20 | ||
| - erc721 | ||
| - erc1155 | ||
| - flipper | ||
| - incrementer | ||
| - multi-contract-caller | ||
| - multi-contract-caller/accumulator | ||
| - multi-contract-caller/adder | ||
| - multi-contract-caller/subber | ||
| - multisig | ||
| - payment-channel | ||
| - psp22-extension | ||
| - rand-extension | ||
| - trait-dyn-cross-contract-calls | ||
| - trait-erc20 | ||
| - trait-flipper | ||
| - trait-incrementer | ||
| - upgradeable-contracts/delegator | ||
| - upgradeable-contracts/set-code-hash | ||
| - vesting |
There was a problem hiding this comment.
The only annoying thing here is that we have to remember to update this list when adding/removing examples.
In ink I have this script to solve that, although wouldn't be usable in this case because it may not work on OSX and obviously not on Windows.
ascjones
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings following optimizations to the CI:
Swatinem/rust-cachewas not configured properly therefore caching did not happen. This PR fixes it.cargo-contractinstallation step also didn't use preferences of caching. Optimization in this PR leads to reduction of this step execution time from ~20min to just few seconds.ubuntu_20_64_corerunners withubuntu-latest, keeping execution time at the same level (build and test against Ubuntu when cache is populated is 15-16min) and slightly slower without cache (25-30min). Related to https://github.com/paritytech/ci_cd/issues/553path-ignorelists to not trigger CI if files likeREADME.mdand so on changed.