Only allow new contract names beginning with an alphabetic character #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
approved these changes
Mar 9, 2021
cmichi
pushed a commit
that referenced
this pull request
Mar 10, 2021
…219) * Only allow contract names beginning with an alphabetic character * Add test for contract name beginning with a number * Add test for contract name beginning with a number
ascjones
added a commit
that referenced
this pull request
Mar 10, 2021
* Revert "Revert me: Remove `--all-features` (#114)" This reverts commit 4a0d352. * Pass verbosity flag * Format use * Run tests without `binaryen-as-dependency` * Update to `scale-info` 0.6 * Fix `value used after move` * Do not continue processing wasm on `check` Results in `No such file` otherwise, since no *.wasm is generated on `check`. * Make casing consistent for `log` messages * Clarify behavior of `check` * Revert me: add debug output * Upgrade `cargo_metadata` to 0.13.1 * Fix assert for target path `target/ink` * Revert "Revert me: add debug output" This reverts commit d2bf1dd. * Revert "Upgrade `cargo_metadata` to 0.13.1" This reverts commit 723c9b2. * Run tests only with `binaryen-as-dependency` * Upgrade cargo-metadata and fix usages (#210) * Only allow new contract names beginning with an alphabetic character (#219) * Only allow contract names beginning with an alphabetic character * Add test for contract name beginning with a number * Add test for contract name beginning with a number * Run tests only with `binaryen-as-dependency` * Refactor * Revert "Refactor" This reverts commit defe20d. Co-authored-by: Andrew Jones <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218